Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754801Ab1FXVpT (ORCPT ); Fri, 24 Jun 2011 17:45:19 -0400 Received: from mail.solarflare.com ([216.237.3.220]:20805 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436Ab1FXVpQ (ORCPT ); Fri, 24 Jun 2011 17:45:16 -0400 Subject: [PATCH] sparse: Fix BUILD_BUG_ON_{ZERO,NULL} definitions From: Ben Hutchings To: LKML Cc: KOSAKI Motohiro Content-Type: text/plain; charset="UTF-8" Organization: Solarflare Communications Date: Fri, 24 Jun 2011 22:45:12 +0100 Message-ID: <1308951912.3034.23.camel@bwh-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 (2.32.2-1.fc14) Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 24 Jun 2011 21:45:14.0944 (UTC) FILETIME=[006D5C00:01CC32B8] X-TM-AS-Product-Ver: SMEX-8.0.0.1181-6.500.1024-18218.005 X-TM-AS-Result: No--15.436700-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 45 Commit 903c0c7cdc21f2ccb7562a7bbc70289c0c2b16ad ('sparse: define dummy BUILD_BUG_ON definition for sparse') left these two broken. The ZERO or NULL suffix specifies what the macro should expand to, not the value that would indicate a bug. Signed-off-by: Ben Hutchings --- sparse currently reports a syntax error and no useful warnings for any source file which uses one of these macros. Since module_param() uses BUILD_BUG_ON_ZERO(), that's a lot of source files. Ben. include/linux/kernel.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index fb0e732..fccd366 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -671,8 +671,8 @@ struct sysinfo { #ifdef __CHECKER__ #define BUILD_BUG_ON_NOT_POWER_OF_2(n) -#define BUILD_BUG_ON_ZERO(e) -#define BUILD_BUG_ON_NULL(e) +#define BUILD_BUG_ON_ZERO(e) ((size_t)0) +#define BUILD_BUG_ON_NULL(e) ((void *)0) #define BUILD_BUG_ON(condition) #else /* __CHECKER__ */ -- 1.7.4.4 -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/