Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751212Ab1FZGME (ORCPT ); Sun, 26 Jun 2011 02:12:04 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:59874 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973Ab1FZGMA convert rfc822-to-8bit (ORCPT ); Sun, 26 Jun 2011 02:12:00 -0400 MIME-Version: 1.0 In-Reply-To: <20110625152009.f264be78.randy.dunlap@oracle.com> References: <20110624155822.cb8cf6eb.sfr@canb.auug.org.au> <20110624090456.191f1fda.randy.dunlap@oracle.com> <1308947172.13493.37.camel@koala> <4E04F5D0.9090900@oracle.com> <1308983721.23868.2.camel@koala> <20110625152009.f264be78.randy.dunlap@oracle.com> From: Grant Likely Date: Sun, 26 Jun 2011 00:11:40 -0600 X-Google-Sender-Auth: bxfuy-fJyt0DtxrOmC9Rq-bsD7I Message-ID: Subject: Re: linux-next: Tree for June 24 (mtd + of) To: Randy Dunlap Cc: dedekind1@gmail.com, Stephen Rothwell , David Woodhouse , linux-mtd@lists.infradead.org, linux-next@vger.kernel.org, LKML , Vitaly Wool Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2687 Lines: 69 On Sat, Jun 25, 2011 at 4:20 PM, Randy Dunlap wrote: > On Sat, 25 Jun 2011 09:35:13 +0300 Artem Bityutskiy wrote: > >> On Fri, 2011-06-24 at 13:38 -0700, Randy Dunlap wrote: >> > On 06/24/11 13:26, Artem Bityutskiy wrote: >> > > On Fri, 2011-06-24 at 09:04 -0700, Randy Dunlap wrote: >> > >> On Fri, 24 Jun 2011 15:58:22 +1000 Stephen Rothwell wrote: >> > >> >> > >>> Hi all, >> > >>> >> > >>> Changes since 20110623: >> > >>> >> > >>> My fixes tree includes: >> > >>> ? ? ? ? (as an experiment) the early part of mmotm-2011-06-22-13-05 >> > >>> ? ? ? ? STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE >> > >> >> > >> >> > >> When CONFIG_MTD=m, CONFIG_MTD_OF_PARTS=y: >> > >> >> > >> drivers/mtd/ofpart.o: In function `init_module': >> > >> ofpart.c:(.init.text+0x0): multiple definition of `init_module' >> > >> drivers/mtd/mtdcore.o:(.init.text+0x43): first defined here >> > > >> > > I guess this is some old issue? I do not think ofpart can be compiled-in >> > > if the mtd core is a module... >> > >> > [adding driver author, Vitaly] >> > >> > No, it's a current issue. >> >> I meant that the subject suggests this is about linux-next, but this >> problem should be in upstream. > > Sorry I misunderstood your comment. > > 3.0-rc4 does not have this build error when I use the .config file with it... > however, I think that 3.0-rc4 also does not build ofpart.ko as it should. > > Looks to me like changes in drivers/mtd/{Kconfig && Makefile} caused this > build error. The following commit in linux-next appears to be the culprit: commit 1a6bc893044b961caae1c5a9c6c2065e608da427 Author: Dmitry Eremin-Solenikov Date: Sun May 29 21:32:33 2011 +0400 mtd: prepare to convert of_mtd_parse_partitions to partition parser Prepare to convert of_mtd_parse_partitions() to usual partitions parser: 1) Register ofpart parser 2) Internally don't use passed device for error printing 3) Add device_node to mtd_part_parser_data struct 4) Move of_mtd_parse_partitions from __devinit to common text section 5) add ofpart to the default list of partition parsers Signed-off-by: Dmitry Eremin-Solenikov Signed-off-by: Artem Bityutskiy It adds a module_init() call to ofpart.c which does not work the way that ofpart.c is linked to mtdcore.o. Seems like that commit series still needs work. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/