Date: Sun, 26 Jun 2011 12:45:21 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Mike Galbraith <mgalbraith@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [rfc patch] x86,apic: fix DEBUG_PREEMPT gripe when booting with
 threadirqs=1
Message-ID: <20110626104521.GE11093@elte.hu>
References: <1308743825.8568.3.camel@marge.simson.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1308743825.8568.3.camel@marge.simson.net>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 814
Lines: 22


* Mike Galbraith <mgalbraith@suse.de> wrote:

> x86,apic: fix DEBUG_PREEMPT gripe when booting with threadirqs=1
> 
> If CONFIG_PREEMPT and CONFIG_INTR_REMAP are both set, and a box is
> booted with threadirqs, the gripe below is emitted.  It was suggested
> that native_smp_prepare_cpus() shouldn't need to be run with preemption
> disabled, and indeed, box boots with no hint of trouble.  Remove it.

Would also require a careful review of the code we take out of 
preempt protection now - have you done that by any chance? (if not, 
mind doing it?)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/