Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756971Ab1F0HG6 (ORCPT ); Mon, 27 Jun 2011 03:06:58 -0400 Received: from ams-iport-2.cisco.com ([144.254.224.141]:52364 "EHLO ams-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754954Ab1F0HFW convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2011 03:05:22 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAF8qCE6Q/khM/2dsb2JhbABSp0N3iHShSZ0yhjAElnqLJg X-IronPort-AV: E=Sophos;i="4.65,431,1304294400"; d="scan'208";a="39385899" X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH v3] Add support for the Philips SA56004 temperature sensor. Date: Mon, 27 Jun 2011 09:04:46 +0200 Message-ID: <6E4D2678AC543844917CA081C9D6B33F04CF4FFC@XMB-AMS-103.cisco.com> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3] Add support for the Philips SA56004 temperature sensor. Thread-Index: Acw0OuLD9ts8TCMfSEa2rhYj8TtcwgAXWa+Q References: <1307356845-10095-1-git-send-email-sdevrien@cisco.com> From: "Stijn Devriendt (sdevrien)" To: "Fubo Chen" Cc: , , , X-OriginalArrivalTime: 27 Jun 2011 07:05:20.0938 (UTC) FILETIME=[93FC98A0:01CC3498] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 17 > On Mon, Jun 6, 2011 at 12:40 PM, wrote: > > + ? ? ? } else > > + ? ? ? if (man_id == 0xA1) { /* ?NXP Semiconductor/Philips */ > > No kernel coder writes like this. Has this ever been run through > checkpatch ? It has. Unfortunately this is just the coding style in the whole driver. I believe it's better to have a consistent file rather than 3 different styles. Stijn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/