Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756137Ab1F1I3k (ORCPT ); Tue, 28 Jun 2011 04:29:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:40115 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755420Ab1F1I0F (ORCPT ); Tue, 28 Jun 2011 04:26:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,436,1304319600"; d="scan'208";a="19149638" Date: Tue, 28 Jun 2011 09:25:40 +0100 From: Alan Cox To: Ralf Baechle Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 10/12] SERIAL: SC26xx: Fix link error. Message-ID: <20110628092540.61c94bf9@bob.linux.org.uk> In-Reply-To: References: <17dd5038b15d7135791aadbe80464a13c80758d3.1309182742.git.ralf@linux-mips.org> Organization: Intel X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Organisation: Intel Corporation UK Ltd, registered no. 1134945 (England), Registered office Pipers Way, Swindon, SN3 1RJ Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 21 On Mon, 27 Jun 2011 14:26:56 +0100 Ralf Baechle wrote: > Kconfig allows enabling console support for the SC26xx driver even > when it's configured as a module resulting in a: > > ERROR: "uart_console_device" [drivers/tty/serial/sc26xx.ko] undefined! > > modpost error since the driver was merged in > eea63e0e8a60d00485b47fb6e75d9aa2566b989b [SC26XX: New serial driver > for SC2681 uarts] in 2.6.25. Fixed by only allowing console support > to be enabled if the driver is builtin. > > Signed-off-by: Ralf Baechle Acked-by: Alan Cox -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/