Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760231Ab1F1R5z (ORCPT ); Tue, 28 Jun 2011 13:57:55 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:36987 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760154Ab1F1R45 convert rfc822-to-8bit (ORCPT ); Tue, 28 Jun 2011 13:56:57 -0400 MIME-Version: 1.0 In-Reply-To: <1309224113-21818-2-git-send-email-sergiu@chromium.org> References: <1309224113-21818-1-git-send-email-sergiu@chromium.org> <1309224113-21818-2-git-send-email-sergiu@chromium.org> Date: Tue, 28 Jun 2011 20:56:56 +0300 Message-ID: Subject: Re: [PATCH 1/3] char drivers: ramoops default platform device for module parameter use From: Daniel Baluta To: Sergiu Iordache Cc: Marco Stornelli , Andrew Morton , "Ahmed S. Darwish" , Artem Bityutskiy , Kyungmin Park , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 22 > +struct platform_device *ramoops_device; This should be static. > + > ?static int __init ramoops_init(void) > ?{ > + ? ? ? /* > + ? ? ? ?* If mem_address and mem_size are set (i.e. the module parameters > + ? ? ? ?* are used) then a default platform driver is created > + ? ? ? ?* as there is no need to configure the platform data elsewhere. > + ? ? ? ?*/ > + ? ? ? if (mem_address && mem_size) { You should get back to this check after introducing record_size. thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/