Subject: Re: [PATCH v3] Add support for the Philips SA56004 temperature
 sensor.
From: Guenter Roeck <guenter.roeck@ericsson.com>
Reply-To: guenter.roeck@ericsson.com
To: Fubo Chen <fubo.chen@gmail.com>
CC: "Stijn Devriendt (sdevrien)" <sdevrien@cisco.com>,
        "khali@linux-fr.org" <khali@linux-fr.org>,
        "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <BANLkTim=9ygJScqy12PQXNPBStSgPbpedQ@mail.gmail.com>
References: <1307356845-10095-1-git-send-email-sdevrien@cisco.com>
	 <BANLkTi=gAqpDNBjCXzvNEhSuzm=3Mg9rVg@mail.gmail.com>
	 <6E4D2678AC543844917CA081C9D6B33F04CF4FFC@XMB-AMS-103.cisco.com>
	 <BANLkTim=9ygJScqy12PQXNPBStSgPbpedQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Organization: Ericsson
Date: Tue, 28 Jun 2011 11:19:48 -0700
Message-ID: <1309285188.12139.1.camel@groeck-laptop>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1010
Lines: 27

On Tue, 2011-06-28 at 13:50 -0400, Fubo Chen wrote:
> On Mon, Jun 27, 2011 at 9:04 AM, Stijn Devriendt (sdevrien)
> <sdevrien@cisco.com> wrote:
> >> On Mon, Jun 6, 2011 at 12:40 PM,  <sdevrien@cisco.com> wrote:
> >> > +       } else
> >> > +       if (man_id == 0xA1) { /*  NXP Semiconductor/Philips */
> >>
> >> No kernel coder writes like this. Has this ever been run through
> >> checkpatch ?
> > It has. Unfortunately this is just the coding style in the whole
> > driver. I believe it's better to have a consistent file rather
> > than 3 different styles.
> 
> Makes sense to me. By the way, it's not forbidden to clean up unusual
> coding style from other developers.
> 
Yes, but as separate patch. Please feel free to submit such a patch.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/