Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698Ab1F1Ukx (ORCPT ); Tue, 28 Jun 2011 16:40:53 -0400 Received: from mail.perches.com ([173.55.12.10]:3269 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab1F1Uks (ORCPT ); Tue, 28 Jun 2011 16:40:48 -0400 Subject: Re: [PATCH] net/core: Convert to current logging forms From: Joe Perches To: Ben Hutchings Cc: netdev@vger.kernel.org, "David S. Miller" , Neil Horman , linux-kernel@vger.kernel.org In-Reply-To: <1309293416.2771.50.camel@bwh-desktop> References: <385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com> <1309292501.2771.48.camel@bwh-desktop> <1309293068.29598.14.camel@Joe-Laptop> <1309293416.2771.50.camel@bwh-desktop> Content-Type: text/plain; charset="UTF-8" Date: Tue, 28 Jun 2011 13:40:46 -0700 Message-ID: <1309293646.29598.17.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 44 On Tue, 2011-06-28 at 21:36 +0100, Ben Hutchings wrote: > On Tue, 2011-06-28 at 13:31 -0700, Joe Perches wrote: > > On Tue, 2011-06-28 at 21:21 +0100, Ben Hutchings wrote: > > > On Tue, 2011-06-28 at 12:40 -0700, Joe Perches wrote: > > > > Use pr_fmt, pr_, and netdev_ as appropriate. > > > > Coalesce long formats. > > > [...] > > > > --- a/net/core/dev.c [] > > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > [...] > > > KBUILD_MODNAME is presumably going to be "dev". > > 'tis. > > > That's not very meaningful. > > Anything else you think it should be? > > Maybe "net_core_device:" or some such like that? > "netdev" Maybe. David? Got an opinion? > > Here are the format strings now prefaced by "dev:" > > > > $ strings net/core/built-in.o |grep "^<.>dev:" > > <6>dev: netif_stop_queue() cannot be called before register_netdev() > > <4>dev: dev_remove_pack: %p not found > > <3>dev: Loading kernel module for a network device with CAP_SYS_MODULE (deprecated) > > <0>dev: %s: failed to move %s to init_net: %d > > <3>dev: alloc_netdev: Unable to allocate device with zero queues > > <3>dev: alloc_netdev: Unable to allocate device with zero RX queues > > <3>dev: alloc_netdev: Unable to allocate device > Many of these refer to a specific device and should be formatted with > one of the netdev_* logging functions. Not true. These are in the alloc_netdev function where netdev_ can not yet be successfully used. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/