Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328Ab1F1VRE (ORCPT ); Tue, 28 Jun 2011 17:17:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921Ab1F1VQ7 (ORCPT ); Tue, 28 Jun 2011 17:16:59 -0400 Date: Tue, 28 Jun 2011 17:16:47 -0400 From: Dave Jones To: David Rientjes Cc: David Daney , Christoph Lameter , Marcin Slusarz , Pekka Enberg , Matt Mackall , LKML , linux-mm@kvack.org Subject: Re: [PATCH] slub: reduce overhead of slub_debug Message-ID: <20110628211647.GB11660@redhat.com> Mail-Followup-To: Dave Jones , David Rientjes , David Daney , Christoph Lameter , Marcin Slusarz , Pekka Enberg , Matt Mackall , LKML , linux-mm@kvack.org References: <20110626193918.GA3339@joi.lan> <4E0A2E26.5000001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 19 On Tue, Jun 28, 2011 at 01:58:06PM -0700, David Rientjes wrote: > SLUB debugging is useful only to diagnose issues or test new code, nobody > is going to be enabling it in production environment. We don't need 30 > new lines of code that make one thing slightly faster During five of the six months of development, Fedora kernels are built with slub debugging forced on. And it turns up problems every single release. Having the impact of this be lower is very desirable. If this doesn't get merged, I'd be tempted to carry it in Fedora regardless for this reason. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/