From: Arnd Bergmann <arnd@arndb.de>
To: Johannes Stezenbach <js@sig21.net>
Subject: Re: missing compat-ioctl for CDROM_DRIVE_STATUS + FDGETPRM
Date: Wed, 29 Jun 2011 14:30:42 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.31-22-generic; KDE/4.3.2; x86_64; ; )
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20110617090424.GA19345@sig21.net> <201106171502.39445.arnd@arndb.de> <20110629113834.GA4227@sig21.net>
In-Reply-To: <20110629113834.GA4227@sig21.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201106291430.43102.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 27

On Wednesday 29 June 2011, Johannes Stezenbach wrote:
> Sorry for very slow reply.  I think qemu's use of these ioctls
> to probe if the device is a cdrom or floppy is valid, so instead
> of adding a stat() call to check for block device in qemu, I think
> it is better to silence the warning in the kernel.

Well, correct or not, it will keep causing annoying messages on
old kernels, so why not do both?

> Do I get it right that just adding two IGNORE_IOCTL() to
> the ioctl_pointer array in linux/fs/compat_ioctl.c is sufficient,
> like in commit 3f001711?

Yes.

> I.e. these ioctls are handled for block devices earlier
> in compat_sys_ioctl()?

Right. We always first ask the driver, and then search the lookup table
when the driver does not know how to handle it in compat mode.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/