Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758612Ab1F3IAS (ORCPT ); Thu, 30 Jun 2011 04:00:18 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:33745 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499Ab1F3IAO (ORCPT ); Thu, 30 Jun 2011 04:00:14 -0400 MIME-Version: 1.0 In-Reply-To: <20110630055719.GA930@opensource.wolfsonmicro.com> References: <1309397507-24959-1-git-send-email-myungjoo.ham@samsung.com> <1309397507-24959-3-git-send-email-myungjoo.ham@samsung.com> <20110630052808.GA796@opensource.wolfsonmicro.com> <20110630055719.GA930@opensource.wolfsonmicro.com> Date: Thu, 30 Jun 2011 17:00:13 +0900 Message-ID: Subject: Re: [PATCH 3/3] MFD: MAX8997: IRQ definition moved to public header. From: MyungJoo Ham To: Mark Brown Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , Kyungmin Park , Liam Girdwood , Donggeun Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 34 On Thu, Jun 30, 2011 at 2:57 PM, Mark Brown wrote: > On Thu, Jun 30, 2011 at 02:56:27PM +0900, MyungJoo Ham wrote: > >> In order to request MAX8997's IRQs, these IRQ enums are required by >> board files (such as /arch/arm/mach-exynos4/mach-*.c). So, these IRQ >> enums are no more "private" to max8997 device drivers. Without this >> patch, board files need to include max8997-private.h. > > Why does the board file need to request these IRQs? > It specifies which interrupts of MAX8997 are used. In our code: http://git.infradead.org/users/kmpark/linux-2.6-samsung/blob/eba500212699c0ad8d6bde0dc01c3ec7101f8154:/arch/arm/mach-exynos4/setup-charger.c around line 85, it specifies which interrupt is going to be a wakeup-source ("true"), how the power-managing S/W should interpret them. The interrupts not listed in the array are not used as a wakeup-source. -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: 82-10-6714-2858 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/