Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758767Ab1F3IUw (ORCPT ); Thu, 30 Jun 2011 04:20:52 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:14598 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682Ab1F3IUq (ORCPT ); Thu, 30 Jun 2011 04:20:46 -0400 X-AuditID: cbfee61b-b7bfdae000006d51-5d-4e0c31dcb9db Date: Thu, 30 Jun 2011 17:20:47 +0900 From: Jaehoon Chung Subject: Re: [PATCH] mmc: dw_mmc: Add the function call for board-specific initialization. In-reply-to: To: James Hogan Cc: Jaehoon Chung , Seungwon Jeon , linux-mmc@vger.kernel.org, cjb@laptop.org, linux-kernel@vger.kernel.org Message-id: <4E0C31DF.5090200@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7BIT User-Agent: Thunderbird 2.0.0.24 (X11/20100623) References: <1309402665-29228-1-git-send-email-tgih.jun@samsung.com> <4E0C18BD.8000608@samsung.com> X-OriginalArrivalTime: 30 Jun 2011 08:20:59.0305 (UTC) FILETIME=[A44DB190:01CC36FE] X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3115 Lines: 101 Hi James James Hogan wrote: > On 30 June 2011 07:33, Jaehoon Chung wrote: >> Hi Mr.Jeon >> >> This patch is the compiler error. >> >> didn't find host->card_work.. >> >> do you want this >> queue_work(dw_mci_card_workqueue, &slot->host->card_work); ? > > I think the patch is based on mmc-next, which has the following commit: > 35ba9d8 mmc: dw_mmc: convert card tasklet to workqueue I also tested this patch based on mmc-next. But my mean is that there is not host structure in dw_mci_detect_interrupt(). drivers/mmc/host/dw_mmc.c: In function 'dw_mci_detect_interrupt': drivers/mmc/host/dw_mmc.c:1592: error: 'host' undeclared (first use in this function) drivers/mmc/host/dw_mmc.c:1592: error: (Each undeclared identifier is reported only once drivers/mmc/host/dw_mmc.c:1592: error: for each function it appears in.) drivers/mmc/host/dw_mmc.c:1590: warning: unused variable 'slot' make[3]: *** [drivers/mmc/host/dw_mmc.o] Error 1 make[2]: *** [drivers/mmc/host] Error 2 Did you really compile fine? Regards, Jaehoon Chung > > Cheers > James > >> >> Regards, >> Jaehoon Chung >> >> >> Seungwon Jeon wrote: >>> Need to call init() function of dw_mci_board. >>> It seems to be omitted to call this function. >>> >>> Signed-off-by: Seungwon Jeon >>> --- >>> drivers/mmc/host/dw_mmc.c | 11 +++++++++++ >>> 1 files changed, 11 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >>> index a524416..073c420 100644 >>> --- a/drivers/mmc/host/dw_mmc.c >>> +++ b/drivers/mmc/host/dw_mmc.c >>> @@ -1585,6 +1585,15 @@ static void dw_mci_work_routine_card(struct work_struct *work) >>> } >>> } >>> >>> +static irqreturn_t dw_mci_detect_interrupt(int irq, void *dev_id) >>> +{ >>> + struct dw_mci_slot *slot = dev_id; >>> + >>> + queue_work(dw_mci_card_workqueue, &host->card_work); >>> + >>> + return IRQ_HANDLED; >>> +} >>> + >>> static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id) >>> { >>> struct mmc_host *mmc; >>> @@ -1657,6 +1666,8 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id) >>> } else >>> regulator_enable(host->vmmc); >>> >>> + host->pdata->init(id, dw_mci_detect_interrupt, host); >>> + >>> if (dw_mci_get_cd(mmc)) >>> set_bit(DW_MMC_CARD_PRESENT, &slot->flags); >>> else >>> -- >>> 1.7.0.4 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/