Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757662Ab1F3In5 (ORCPT ); Thu, 30 Jun 2011 04:43:57 -0400 Received: from mail-fx0-f52.google.com ([209.85.161.52]:50578 "EHLO mail-fx0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755864Ab1F3Ins convert rfc822-to-8bit (ORCPT ); Thu, 30 Jun 2011 04:43:48 -0400 MIME-Version: 1.0 In-Reply-To: <20110630080119.GA20802@infradead.org> References: <20110629140630.5aefdda8.rdunlap@xenotime.net> <20110630080119.GA20802@infradead.org> Date: Thu, 30 Jun 2011 10:43:47 +0200 X-Google-Sender-Auth: oiZrexSdhxHzv_hoGDzmuWv5W2I Message-ID: Subject: Re: Build regressions/improvements in v3.0-rc5 (ssize_t ???) From: Geert Uytterhoeven To: Christoph Hellwig Cc: Randy Dunlap , Linux Kernel Development , Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 38 On Thu, Jun 30, 2011 at 10:01, Christoph Hellwig wrote: > On Thu, Jun 30, 2011 at 08:59:28AM +0200, Geert Uytterhoeven wrote: >> Nope. Also only happens on cris, which has in >> arch/cris/include/asm/posix_types.h: >> >> typedef long            __kernel_ssize_t; >> >> The "long" should be "int". >> But probably it should just include instead. > > Changing a user visible type won't be very nice for those using it in > C++ code. Are __kernel_* types exported to C++ userspace? > Better fix the code to use the proper %zd specifier for printing ssize_t > variables. We cannot, as that would break on all other platforms that use the correct ssize_t. The problem is the incorrect typedef in the cris headers. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/