From: Ashish Jangam <Ashish.Jangam@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
CC: "jic23@cam.ac.uk" <jic23@cam.ac.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dajun <dajun.chen@diasemi.com>,
        "grant@secretlab.ca" <grant@secretlab.ca>
Date: Thu, 30 Jun 2011 17:10:31 +0530
Subject: RE: [PATCH 02/11] GPIO: DA9052 GPIO module v1
Thread-Topic: [PATCH 02/11] GPIO: DA9052 GPIO module v1
Thread-Index: Acw26DOFy0nYiIvFQ6ytHGMNrhzvLAAMOoRw
Message-ID: <E2CAE7F7B064EA49B5CE7EE9A4BB167D152EB8925D@KCINPUNHJCMS01.kpit.com>
References: <1309355591.2344.4.camel@L-0532.kpit.com>
 <20110630053711.GB796@opensource.wolfsonmicro.com>
In-Reply-To: <20110630053711.GB796@opensource.wolfsonmicro.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1189
Lines: 31

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Thursday, June 30, 2011 11:07 AM
> To: Ashish Jangam
> Cc: jic23@cam.ac.uk; linux-kernel@vger.kernel.org; Dajun; grant@secretlab.ca
> Subject: Re: [PATCH 02/11] GPIO: DA9052 GPIO module v1
> 
> On Wed, Jun 29, 2011 at 07:23:11PM +0530, ashishj3 wrote:
> 
> > DA9052 PMIC has 16 bit GPIO bus for peripheral control.
> >
> > This patch add support for the GPIO pins on the DA9052.
> 
> > +	gpio->da9052 = dev_get_drvdata(pdev->dev.parent);
> > +	pdata = gpio->da9052->dev->platform_data;
> > +
> > +	if (pdata == NULL) {
> > +		dev_err(&pdev->dev, "Failed no platform data for GPIO\n");
> > +		ret = -ENOMEM;
> > +		goto err_mem;
> > +	}
> 
> Why insist on platform data?  gpiolib can dynamically allocate a GPIO
> range to the device.
Do you mean to use gpiochip_reserve() in machine file and not to have ngpio 
and base defined in GPIO platform driver but, this will fail the call to gpiochip_add()?
Can you elaborate on it?


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?