Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478Ab1F3PJ6 (ORCPT ); Thu, 30 Jun 2011 11:09:58 -0400 Received: from mail-fx0-f52.google.com ([209.85.161.52]:33162 "EHLO mail-fx0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714Ab1F3PJy (ORCPT ); Thu, 30 Jun 2011 11:09:54 -0400 From: Marek Vasut To: Stanislav Brabec Subject: Re: kernel panic in spi_complete() on spitz (PXA270) Date: Thu, 30 Jun 2011 17:09:48 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.39-1-amd64; KDE/4.6.3; x86_64; ; ) Cc: linux-arm-kernel@lists.infradead.org, zaurus-devel@www.linuxtogo.org, spi-devel-general@lists.sourceforge.net, Igor Grinberg , vapier@gentoo.org, khilman@deeprootsystems.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, pavel@ucw.cz, linux-input@vger.kernel.org, eric.y.miao@gmail.com, akpm@linux-foundation.org, broonie@opensource.wolfsonmicro.com, Pavel Herrmann References: <1308845380.4533.54.camel@oct.suse.cz> <201106301352.21684.marek.vasut@gmail.com> <1309445118.4406.47.camel@oct.suse.cz> In-Reply-To: <1309445118.4406.47.camel@oct.suse.cz> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106301709.48818.marek.vasut@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 37 On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote: > Marek Vasut wrote: > > On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote: > > > Hallo. > > > > > > These Oops and kernel panic were observed on a Zaurus (spitz) machine > > > (ARMv5, PXA270). > > > > Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on > > regulator" > > I don't see any trace in that thread. But yes, I was testing your patch > from this thread. Without it, ADS7846 does not work on spitz (ADS7846 > does not have any dedicated regulator there). I want to > add .needs_regulator bool to ads7846.c and send the patch again to the > list. > > After sending the trace I was able to reproduced it several times by > attaching of external charger. > > Then I tried to apply "[PATCH] MAX1111: Fix race condition causing NULL > pointer exception", connected charger that periodically disconnects and > not seen the crash again. No OOPS was seen after ~100 reconnects. > > So I guess that MAX1111 AC voltage reading (via SPI) was involved in an > incorrect moment and race happened there and your MAX1111 race condition > fix fixes it. It's not mine, it's from Pavel Herrmann actually ;-) But yes, it's likely either this or the regulator stuff again (which I believed was fixed). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/