Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751312Ab1F3QAH (ORCPT ); Thu, 30 Jun 2011 12:00:07 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:54791 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750999Ab1F3QAE (ORCPT ); Thu, 30 Jun 2011 12:00:04 -0400 Date: Thu, 30 Jun 2011 08:59:58 -0700 From: Mark Brown To: Igor Grinberg Cc: Stanislav Brabec , Marek Vasut , linux-arm-kernel@lists.infradead.org, zaurus-devel@www.linuxtogo.org, spi-devel-general@lists.sourceforge.net, vapier@gentoo.org, khilman@deeprootsystems.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, pavel@ucw.cz, linux-input@vger.kernel.org, eric.y.miao@gmail.com, akpm@linux-foundation.org Subject: Re: kernel panic in spi_complete() on spitz (PXA270) Message-ID: <20110630155957.GF3249@opensource.wolfsonmicro.com> References: <1308845380.4533.54.camel@oct.suse.cz> <201106301352.21684.marek.vasut@gmail.com> <1309445118.4406.47.camel@oct.suse.cz> <4E0C957F.8080807@compulab.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E0C957F.8080807@compulab.co.il> X-Cookie: You are always busy. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 27 On Thu, Jun 30, 2011 at 06:25:51PM +0300, Igor Grinberg wrote: > On 06/30/11 17:45, Stanislav Brabec wrote: > > from this thread. Without it, ADS7846 does not work on spitz (ADS7846 > > does not have any dedicated regulator there). I want to > > add .needs_regulator bool to ads7846.c and send the patch again to the > > list. > Please, don't... > I thought we've finished discussing the regulator issue... > Instead of patching the driver and the platform data and the board file, > you should do _either_ of the following: > 1) add regulator definition for ads7846 into the board file > 2) enable the CONFIG_REGULATOR_DUMMY in your kernel configuration > 3) use regulator_use_dummy_regulator() call in the board file. > Using either of the above, you will not need the patch for ads7846, only for the board file. Yes, we've been through this repeatedly. None of these options take any appreciable time to implement, it'd be much more productive to just do so. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/