Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753098Ab1F3RKl (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Jun 2011 13:10:41 -0400
Received: from mail.perches.com ([173.55.12.10]:3369 "EHLO mail.perches.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751122Ab1F3RKj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Jun 2011 13:10:39 -0400
Subject: Re: [PATCH] net/core: Convert to current logging forms
From: Joe Perches <joe@perches.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <iuhh76$fid$1@dough.gmane.org>
References: <385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com>
	 <iuhh76$fid$1@dough.gmane.org>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 30 Jun 2011 10:10:37 -0700
Message-ID: <1309453837.7277.3.camel@Joe-Laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.2 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1138
Lines: 32

On Thu, 2011-06-30 at 09:55 +0000, WANG Cong wrote:
> On Tue, 28 Jun 2011 12:40:10 -0700, Joe Perches wrote:
> > Use pr_fmt, pr_<level>, and netdev_<level> as appropriate.
> > Coalesce long formats.
> > +		np->name, np->local_port);
> > +	pr_info("%s: local IP %pI4\n",
> > +		np->name, &np->local_ip);
> > +	pr_info("%s: interface '%s'\n",
> > +		np->name, np->dev_name);
> > +	pr_info("%s: remote port %d\n",
> > +		np->name, np->remote_port);
> > +	pr_info("%s: remote IP %pI4\n",
> > +		np->name, &np->remote_ip);
> > +	pr_info("%s: remote ethernet address %pM\n",
> > +		np->name, np->remote_mac);
> >  }
> This doesn't have much value, because the name of the netpoll
> user (np->name) is already logged. If we changed it,
> we would see "netconsole: netconsole: blah blah...".

Thanks.

Don't just reply to the lists.
Remember to include the patch author in your replies.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/