Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758Ab1F3TF2 (ORCPT ); Thu, 30 Jun 2011 15:05:28 -0400 Received: from terminus.zytor.com ([198.137.202.10]:59359 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708Ab1F3TF1 (ORCPT ); Thu, 30 Jun 2011 15:05:27 -0400 Message-ID: <4E0CC824.40909@zytor.com> Date: Thu, 30 Jun 2011 12:01:56 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Mike Frysinger CC: Arnd Bergmann , Markus Trippelsdorf , Michal Marek , Joe Perches , Nick Bowler , "linux-kernel@vger.kernel.org" , Sam Ravnborg , Artem Bityutskiy Subject: Re: {PATCH] fix __packed in exported kernel headers References: <20110622063441.GA1740@x4.trippels.de> <4E048C0D.7020403@suse.cz> <20110624135100.GB1708@x4.trippels.de> <201106241833.15424.arnd@arndb.de> <4E0CBFF0.2040205@zytor.com> <4E0CC5F4.7010002@zytor.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 27 On 06/30/2011 11:58 AM, Mike Frysinger wrote: > On Thu, Jun 30, 2011 at 14:52, H. Peter Anvin wrote: >> On 06/30/2011 11:48 AM, Mike Frysinger wrote: >>> without fallback logic (#ifndef xxx...#define xxx...#endif), i think >>> that's throwing an unreasonable amount of requirements onto userspace >>> consumers >> >> Unclear. Too much "smarts" in kernel headers is a constant headache to >> userspace consumers. > > not even being able to include a header without hitting a build > failure without first declaring some magic defines (which, > realistically, the vast majority of people will be doing exactly the > same as they'll be using gcc) is unreasonable. hence my suggestion > about compiler.h. > Not unless the kernel uses its own namespace for these defines. The thing is, most libraries have their own macro library for this, and collisions are both likely and bad. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/