Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159Ab1F3Tr5 (ORCPT ); Thu, 30 Jun 2011 15:47:57 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:44831 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926Ab1F3Tr4 (ORCPT ); Thu, 30 Jun 2011 15:47:56 -0400 Date: Thu, 30 Jun 2011 15:47:54 -0400 From: Christoph Hellwig To: "K. Y. Srinivasan" Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, Haiyang Zhang , Abhishek Kane , Hank Janssen Subject: Re: [PATCH 38/40] Staging: hv: storvsc: Fixup srb_status for INQUIRY and MODE_SENSE Message-ID: <20110630194754.GG22707@infradead.org> References: <1309358301-8488-1-git-send-email-kys@microsoft.com> <1309358377-8537-1-git-send-email-kys@microsoft.com> <1309358377-8537-38-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1309358377-8537-38-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 27 On Wed, Jun 29, 2011 at 07:39:35AM -0700, K. Y. Srinivasan wrote: > The current handler on the Windows Host does not correctly handle > INQUIRY and MODE_SENSE commands with some options. Fixup srb_status > in these cases since the failure is not fatal. > + /* > + * The current SCSI handling on the host side does > + * not correctly handle: > + * INQUIRY command with page code parameter set to 0x80 > + * MODE_SENSE command with cmd[2] == 0x1c > + * > + * Setup srb status so this won't be fatal. > + */ > + > + if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) || > + (stor_pkt->vm_srb.cdb[0] == MODE_SENSE)) > + vstor_packet->vm_srb.srb_status = 0; Given that the srb_status is only used for debug printks I don't quite see the point. If people explicitly turn on debugging they should see that these commands fail, shouldn't they? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/