Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775Ab1F3X2b (ORCPT ); Thu, 30 Jun 2011 19:28:31 -0400 Received: from smtp.microsoft.com ([131.107.115.215]:55852 "EHLO smtp.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753Ab1F3X22 convert rfc822-to-8bit (ORCPT ); Thu, 30 Jun 2011 19:28:28 -0400 From: KY Srinivasan To: Christoph Hellwig CC: "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" Subject: RE: [PATCH 00/40] Staging: hv: Driver cleanup Thread-Topic: [PATCH 00/40] Staging: hv: Driver cleanup Thread-Index: AQHMNmfj17zjqSVuBEq2aM1XFV3FGpTWwcoA///LLvA= Date: Thu, 30 Jun 2011 23:28:27 +0000 Message-ID: <6E21E5352C11B742B20C142EB499E0480816C36D@TK5EX14MBXC126.redmond.corp.microsoft.com> References: <1309358301-8488-1-git-send-email-kys@microsoft.com> <20110630193346.GA22707@infradead.org> In-Reply-To: <20110630193346.GA22707@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.54.51.32] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 40 > -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: Thursday, June 30, 2011 3:34 PM > To: KY Srinivasan > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; virtualization@lists.osdl.org > Subject: Re: [PATCH 00/40] Staging: hv: Driver cleanup > > On Wed, Jun 29, 2011 at 07:38:21AM -0700, K. Y. Srinivasan wrote: > > Further cleanup of the hv drivers: > > > > 1) Cleanup the reference counting mess for both stor and net devices. > > I really don't understand the need for reference counting on the storage > side, especially now that you only have a SCSI driver. The SCSI > midlayer does proper counting on it's objects (Scsi_Host, scsi_device, > scsi_cmnd), so you'll get that for free given that SCSI drivers just > piggyback on the midlayer lifetime rules. The reference counting allows us to properly deal with messages coming back from the host to the guest with a racing remove of the device. I am told these messages could potentially be not a response to a message sent from the guest. > > For now your patches should probably go in as-is, but mid-term you > should be able to completely remove that code on the storage side. > Thanks. Sure, we will always try to simplify the code. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/