Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753735Ab1F3XsQ (ORCPT ); Thu, 30 Jun 2011 19:48:16 -0400 Received: from mail.vyatta.com ([76.74.103.46]:49432 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456Ab1F3XsN (ORCPT ); Thu, 30 Jun 2011 19:48:13 -0400 Date: Thu, 30 Jun 2011 16:48:08 -0700 From: Stephen Hemminger To: KY Srinivasan Cc: Christoph Hellwig , "devel@linuxdriverproject.org" , "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "virtualization@lists.osdl.org" Subject: Re: [PATCH 00/40] Staging: hv: Driver cleanup Message-ID: <20110630164808.17c506a4@nehalam.ftrdhcpuser.net> In-Reply-To: <6E21E5352C11B742B20C142EB499E0480816C384@TK5EX14MBXC126.redmond.corp.microsoft.com> References: <1309358301-8488-1-git-send-email-kys@microsoft.com> <20110630193346.GA22707@infradead.org> <6E21E5352C11B742B20C142EB499E0480816C384@TK5EX14MBXC126.redmond.corp.microsoft.com> Organization: Vyatta X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1834 Lines: 41 On Thu, 30 Jun 2011 23:32:34 +0000 KY Srinivasan wrote: > > > -----Original Message----- > > From: Christoph Hellwig [mailto:hch@infradead.org] > > Sent: Thursday, June 30, 2011 3:34 PM > > To: KY Srinivasan > > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; virtualization@lists.osdl.org > > Subject: Re: [PATCH 00/40] Staging: hv: Driver cleanup > > > > On Wed, Jun 29, 2011 at 07:38:21AM -0700, K. Y. Srinivasan wrote: > > > Further cleanup of the hv drivers: > > > > > > 1) Cleanup the reference counting mess for both stor and net devices. > > > > I really don't understand the need for reference counting on the storage > > side, especially now that you only have a SCSI driver. The SCSI > > midlayer does proper counting on it's objects (Scsi_Host, scsi_device, > > scsi_cmnd), so you'll get that for free given that SCSI drivers just > > piggyback on the midlayer lifetime rules. > > > > For now your patches should probably go in as-is, but mid-term you > > should be able to completely remove that code on the storage side. > > > > Greg, > > I am thinking of going back to my original implementation where I had one scsi host > per IDE device. This will certainly simply the code. Let me know what you think. If you > agree with this approach, please drop this patch-set, I will send you a new set of patches. I think there ref counting on network devices is also unneeded as long as the unregister logic handles RCU correctly. The network layer calls the driver unregister routine after all packets are gone. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/