Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701Ab1GABWC (ORCPT ); Thu, 30 Jun 2011 21:22:02 -0400 Received: from mga11.intel.com ([192.55.52.93]:59675 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670Ab1GABWA (ORCPT ); Thu, 30 Jun 2011 21:22:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,455,1304319600"; d="scan'208";a="22575018" Message-ID: <4E0D2137.3000001@linux.intel.com> Date: Thu, 30 Jun 2011 18:21:59 -0700 From: "H. Peter Anvin" Organization: Intel Open Source Technology Center User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Brian Gerst CC: Greg Dietsche , "H. Peter Anvin" , mingo@redhat.com, linux-kernel@vger.kernel.org, Gregory.Dietsche@cuw.edu, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/cleanups] x86, smpboot: Mark names[] array as const References: <1309473108-5337-1-git-send-email-Gregory.Dietsche@cuw.edu> <4E0D1400.7020107@zytor.com> <20110701004121.GA18671@farmergreg.com> <4E0D191C.5090208@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 27 On 06/30/2011 06:20 PM, Brian Gerst wrote: > On Thu, Jun 30, 2011 at 8:47 PM, H. Peter Anvin wrote: >> On 06/30/2011 05:41 PM, Greg Dietsche wrote: >>> On Thu, Jun 30, 2011 at 05:25:36PM -0700, H. Peter Anvin wrote: >>>> On 06/30/2011 05:21 PM, tip-bot for Greg Dietsche wrote: >>>>> + const char const *names[] = { "ID", "VERSION", "SPIV" }; >>>> ^^^^^^^^^^^^^^^^ >>>> >>>> Doesn't make sense, patch removed... >>>> >>> could you explain a little more? I don't see my mistake. >>> it compiles and is running on my box currently. >>> > > One const is for the strings, the other is for the array of pointers. > Yes, the syntax is wrong for that. const char * const names[] is I think what he wanted. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/