Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990Ab1GACDm (ORCPT ); Thu, 30 Jun 2011 22:03:42 -0400 Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:49258 "EHLO na3sys009aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511Ab1GACDl convert rfc822-to-8bit (ORCPT ); Thu, 30 Jun 2011 22:03:41 -0400 From: Xiangliang Yu To: Dan Williams , "yxlraid@gmail.com" CC: "JBottomley@parallels.com" , "James.Bottomley@suse.de" , "jack_wang@usish.com" , "lucas.demarchi@profusion.mobi" , "maciej.trela@intel.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jacky Feng Date: Thu, 30 Jun 2011 19:03:27 -0700 Subject: RE: [PATCH 9/9] [SCSI] mvsas: Add support for interrupt tasklet Thread-Topic: [PATCH 9/9] [SCSI] mvsas: Add support for interrupt tasklet Thread-Index: Acw3TanwceDS/4dlTKOvJaKpKOcw3QAQle2w Message-ID: References: <1309444056-29277-1-git-send-email-yxlraid@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 28 >Subject: Re: [PATCH 9/9] [SCSI] mvsas: Add support for interrupt tasklet >On Thu, Jun 30, 2011 at 7:27 AM, wrote: >> From: Xiangliang Yu >> >> -- Add support for interrupt tasklet, which will improve performance. >Interesting, do you happen to have comparative performance numbers? According to internal test, the increase of tasklet performance is about 1.5MB. This is first step, I will continue to enhance the performance. >> >> ?ccflags-$(CONFIG_SCSI_MVSAS_DEBUG) := -DMV_DEBUG >> +ccflags-$(CONFIG_SCSI_MVSAS_TASKLET) := -DMVS_USE_TASKLET >Question, why not just use "#ifdef CONFIG_SCSI_MVSAS_TASKLET" and drop >these redefinitions? I think the Tasklet is a experimental feature, if any problem, the user Can close the feature. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/