Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756050Ab2BAJOu (ORCPT ); Wed, 1 Feb 2012 04:14:50 -0500 Received: from mail-tul01m020-f174.google.com ([209.85.214.174]:52219 "EHLO mail-tul01m020-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188Ab2BAJOr (ORCPT ); Wed, 1 Feb 2012 04:14:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <1327269381-20748-1-git-send-email-richard@nod.at> <1327269381-20748-2-git-send-email-richard@nod.at> Date: Wed, 1 Feb 2012 10:14:46 +0100 Message-ID: Subject: Re: [PATCH 1/6] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG From: richard -rw- weinberger To: Jan Engelhardt Cc: Netfilter Developer Mailing List , Linux Networking Developer Mailing List , Linux Kernel Mailing List , eric.dumazet@gmail.com, Pablo Neira Ayuso Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 42 On Wed, Feb 1, 2012 at 2:24 AM, Jan Engelhardt wrote: > On Monday 2012-01-30 10:01, richard -rw- weinberger wrote: > >>On Sun, Jan 22, 2012 at 10:56 PM, Richard Weinberger wrote: >>> ipt_LOG and ip6_LOG have a lot of common code, merge them >>> to reduce duplicate code. >>> >>> Signed-off-by: Richard Weinberger >> >>No comments? > > Adding Pablo to Cc. > > > Do you have the patchset as a retrievable git tree, btw? Only for kernel stuff: git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc.git xt_LOG If you want it for the user space part too, I can setup something... > >>[PATCH 6/6] iptables: xt_LOG: Add ring buffer support >> >>in libxt_LOG.c: >>+.size = XT_ALIGN(sizeof(struct xt_log_info_v1) + sizeof(void *)), > > Why the extra void*? The kernel space part of xt_log_info_v1 differs from the user space struct, it contains an extra pointer to the ring buffer context. Iptables must not see this extra pointer because the kernel writes to it. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/