Date: Wed, 1 Feb 2012 15:52:04 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        alan@lxorguk.ukuu.org.uk, Herbert Xu <herbert@gondor.hengli.com.au>
Subject: Re: [06/20] crypto: sha512 - reduce stack usage to safe number
Message-ID: <20120201235204.GA18950@kroah.com>
References: <20120201210055.GA25374@kroah.com>
 <20120201201531.599621544@clark.kroah.org>
 <20120201234208.GA28700@p183.telecom.by>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120201234208.GA28700@p183.telecom.by>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1183
Lines: 32

On Thu, Feb 02, 2012 at 02:42:08AM +0300, Alexey Dobriyan wrote:
> On Wed, Feb 01, 2012 at 12:14:08PM -0800, Greg KH wrote:
> > @@ -87,38 +87,48 @@ sha512_transform(u64 *state, const u8 *i
> >  	u64 a, b, c, d, e, f, g, h, t1, t2;
> >  
> >  	int i;
> > -	u64 W[80];
> > +	u64 W[16];
> 
> This needs 3rd companion patch which does stack reduction even on i386.
> Patch which removes excessive loop unrolling and thus fixes the problem
> has been posted. Maybe there is some other way to maintain low stack
> space on i386 but I haven't found it.
> 
> http://marc.info/?l=linux-netdev&m=132768692525017&w=4
> 
> If you apply only 2, original bug will be fixed, but on at least i386
> stack usage could go in 900-byte region.

But this patch isn't in Linus's tree yet, right?

So, should I just drop this one for now (well both of them) or just wait
for the above referenced patch to hit Linus's tree and handle it then?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/