Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550Ab2BBHdK (ORCPT ); Thu, 2 Feb 2012 02:33:10 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:42646 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869Ab2BBHdI (ORCPT ); Thu, 2 Feb 2012 02:33:08 -0500 Message-ID: <4F2A3C27.5080504@gmail.com> Date: Thu, 02 Feb 2012 15:32:55 +0800 From: Cong Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Dave Young CC: Andrew Morton , Dave Young , Linux Kernel Mailing List Subject: Re: [PATCH] move vm tools from Documentation/vm/ to tools/ References: <20120201063420.GA10204@darkstar.nay.redhat.com> <20120201131746.07e2219e.akpm@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 51 On 02/02/2012 10:13 AM, Dave Young wrote: > On Thu, Feb 2, 2012 at 5:17 AM, Andrew Morton wrote: >> On Wed, 1 Feb 2012 14:34:20 +0800 >> Dave Young wrote: >> >>> tools/ is the better place for vm tools which are used by many people. >>> Moving them to tools also make them open to more users instead of hide in >>> Documentation folder. >>> >> >> It would be nice to covert these into simple pass/fail tests and >> promote them to tools/testing/selftests/. > > Andrew, I'm not clear about this, do you means to selftest > hugepage-mmap.c, hugepage-shm.c and map_hugetlb.c? I think slabinfo > and page-types should stay in tools/vm/. Can you explain a bit? > Hey, Check the comments in these files: /* * hugepage-mmap: * * Example of using huge page memory in a user application using the mmap * system call. /* * hugepage-shm: * * Example of using huge page memory in a user application using Sys V shared * memory system calls. In this example the app is requesting 256MB of * memory that is backed by huge pages. The application uses the flag * SHM_HUGETLB in the shmget system call to inform the kernel that it is * requesting huge pages. /* * Example of using hugepage memory in a user application using the mmap * system call with MAP_HUGETLB flag. All of them are examples, not tests, not tools, thus Documentation/ is the best place for them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/