Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756380Ab2BBUjG (ORCPT ); Thu, 2 Feb 2012 15:39:06 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:55118 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756000Ab2BBUjD convert rfc822-to-8bit (ORCPT ); Thu, 2 Feb 2012 15:39:03 -0500 MIME-Version: 1.0 In-Reply-To: <4F2A5ED1.3040109@jp.fujitsu.com> References: <1327690515-2991-1-git-send-email-yinghai@kernel.org> <4F2A5ED1.3040109@jp.fujitsu.com> Date: Thu, 2 Feb 2012 12:39:01 -0800 X-Google-Sender-Auth: LzC6LCw0JSy8J9o5TwPhVT0fRzg Message-ID: Subject: Re: [PATCH -v2 0/7] PCI: pcie hotplug related patch From: Yinghai Lu To: Kenji Kaneshige Cc: Jesse Barnes , Linus Torvalds , Matthew Wilcox , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 46 On Thu, Feb 2, 2012 at 2:00 AM, Kenji Kaneshige wrote: > Yinghai, Jesse, > > I tested pciehp with your set of patches. I have some comments below. > > (1) I got a following warning message on compiling the patch [5/7]. > > ? ?drivers/pci/hotplug/pciehp_hpc.c:281: warning: > 'pcie_wait_link_not_active' defined but not used > > (2) I got following warning messages on compiling the patch [6/7] > > ? ?drivers/pci/hotplug/pciehp_hpc.c:381: warning: 'pciehp_link_enable' > defined but not used > ? ?drivers/pci/hotplug/pciehp_hpc.c:386: warning: 'pciehp_link_disable' > defined but not used > > (3) I've asked Naoki Yanagimoto, who reported that configuration read > ? ?on some hot-added PCIe device returns invalid value, to test the > ? ?patch. Unfortunately, the problem happens with your patch. But > ? ?after some discussion and testing, it turned out that problem doesn't > ? ?happen when the same card with updated bios is used. So it seems the > ? ?problem is in PCIe card side. > > As a result, problems I found are (1) and (2). Please fix those. > Other than that, pciehp seems to work well. > > Tested-by: Kenji Kaneshige > Great. thanks for confirmation. for (1) and (2), patch 5, and 6 will add some helper functions and they will be used by patch 7. so when patch 7 is applied, there will be no compiling warning anymore. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/