Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933618Ab2BCCAc (ORCPT ); Thu, 2 Feb 2012 21:00:32 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:35129 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932779Ab2BCCAa convert rfc822-to-8bit (ORCPT ); Thu, 2 Feb 2012 21:00:30 -0500 MIME-Version: 1.0 In-Reply-To: <20120203014533.GT23916@ZenIV.linux.org.uk> References: <20120202012258.GQ23916@ZenIV.linux.org.uk> <20120202212400.GR23916@ZenIV.linux.org.uk> <20120203011612.GS23916@ZenIV.linux.org.uk> <20120203014533.GT23916@ZenIV.linux.org.uk> From: Linus Torvalds Date: Thu, 2 Feb 2012 18:00:10 -0800 X-Google-Sender-Auth: TL3gptPkt3xiM5nwrhuZQMTdfyA Message-ID: Subject: Re: [RFC] killing boilerplate checks in ->link/->mkdir/->rename To: Al Viro Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Becker , Chris Mason , David Miller Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 26 On Thu, Feb 2, 2012 at 5:45 PM, Al Viro wrote: > > Incidentally, why the hell do we have > ? ? ? ?typedef __kernel_nlink_t ? ? ? ?nlink_t; > anyway? ?It's *not* exposed to userland and it's different from the > userland nlink_t (which is unsigned int on 32bit and unsigned long on 64bit). > Why not use __kernel_nlink_t (or explicitly-sized __uNN) in > arch/*/include/asm/stat.h and declare nlink_t kernel-side as __u32? Probably hysterical raisins, and just converted to the whole __kernel_nlink_t form together with other, more relevant things. Feel free to remove it. > Why do we have daddr_t, while we are at it? ?There is exactly one user - > fs/freevxfs and there we definitely want a fixed-sized type. I think it's something that probably came from freevxfs and BSD roots or similar. It's a BSD'ism, afaik. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/