From: Venu Byravarasu <vbyravarasu@nvidia.com>
To: "dedekind1@gmail.com" <dedekind1@gmail.com>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        "Voss, Nikolaus" <N.Voss@weinmann.de>,
        =?utf-8?B?RXJpYyBCw6luYXJk?= <eric@eukrea.com>
CC: "'linux-mtd@lists.infradead.org'" <linux-mtd@lists.infradead.org>,
        "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Date: Fri, 3 Feb 2012 09:05:29 +0530
Subject: RE: [PATCH] mtd: atmel_nand: fix access to 16 bit NAND devices
Thread-Topic: [PATCH] mtd: atmel_nand: fix access to 16 bit NAND devices
Thread-Index: Aczhou94g2X+EODkR2yEqVGrbCEVswAgKUgQ
Message-ID: <D958900912E20642BCBC71664EFECE3E6DD0B99114@BGMAIL02.nvidia.com>
References: <201201251217.q0PCHmRe027024@gatekeeper.vosshq.de>
	 <1327670996.26648.43.camel@sauron.fi.intel.com>
	 <EF2E73589CA71846A15D0B2CDF79505D08AD3E5453@wm021.weinmann.com>
	 <4F265B7E.6060806@atmel.com>
 <1328184370.28171.175.camel@sauron.fi.intel.com>
In-Reply-To: <1328184370.28171.175.camel@sauron.fi.intel.com>
Accept-Language: en-US
acceptlanguage: en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 691
Lines: 16

I see a problem with atmel_read_buf16 & atmel_write_buf16 functions.
As they are calling __raw_readsw & __raw_writesw respectively, which 
would cause panic in cases of 16 bit unaligned buffers.
However, the buf passed to these functions is of type u8* from 
atmel_read_buf & atmel_write_buf functions.

[Venu] 
> -	/* if no DMA operation possible, use PIO */
> -	memcpy_fromio(buf, chip->IO_ADDR_R, len);
> +	if (host->board->bus_width_16)
> +		atmel_read_buf16(mtd, buf, len);

> +	else
> +		atmel_read_buf8(mtd, buf, len);
>  }
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?