Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755944Ab2BCKmb (ORCPT ); Fri, 3 Feb 2012 05:42:31 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:37962 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755794Ab2BCKma convert rfc822-to-8bit (ORCPT ); Fri, 3 Feb 2012 05:42:30 -0500 MIME-Version: 1.0 In-Reply-To: <4F2BB715.8090803@mvista.com> References: <1328255503-17575-1-git-send-email-xiyou.wangcong@gmail.com> <4F2BB715.8090803@mvista.com> Date: Fri, 3 Feb 2012 11:42:29 +0100 X-Google-Sender-Auth: 0VIJ_JdIqTzDV-8ukczOExntKlU Message-ID: Subject: Re: [Patch] mips: do not redefine BUILD_BUG() From: Geert Uytterhoeven To: Sergei Shtylyov Cc: Cong Wang , linux-kernel@vger.kernel.org, Andrew Morton , Ralf Baechle , David Daney , Hillf Danton , linux-mips@linux-mips.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 32 On Fri, Feb 3, 2012 at 11:29, Sergei Shtylyov wrote: >> include/linux/kernel.h:717:1: error: "BUILD_BUG" redefined >> arch/mips/include/asm/page.h:43:1: error: this is the location of the >> previous definition >> --- a/arch/mips/include/asm/page.h >> +++ b/arch/mips/include/asm/page.h >> @@ -39,9 +39,7 @@ >>  #define HPAGE_MASK    (~(HPAGE_SIZE - 1)) >>  #define HUGETLB_PAGE_ORDER    (HPAGE_SHIFT - PAGE_SHIFT) >>  #else /* !CONFIG_HUGETLB_PAGE */ >> -# ifndef BUILD_BUG > >   Not clear why we get the error if we're protected with #ifndef... Because this is the first definition. It's redefined later. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/