Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756596Ab2BCOIx (ORCPT ); Fri, 3 Feb 2012 09:08:53 -0500 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:42625 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661Ab2BCOIv (ORCPT ); Fri, 3 Feb 2012 09:08:51 -0500 Date: Fri, 3 Feb 2012 09:08:34 -0500 From: Christoph Hellwig To: Wu Fengguang Cc: Amit Sahrawat , Jan Kara , Andrew Morton , Peter Zijlstra , Johannes Weiner , Amit Sahrawat , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: make do_writepages() use plugging Message-ID: <20120203140834.GA15495@infradead.org> References: <1328275626-5322-1-git-send-email-amit.sahrawat83@gmail.com> <20120203133823.GB17571@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120203133823.GB17571@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 20 On Fri, Feb 03, 2012 at 09:38:23PM +0800, Wu Fengguang wrote: > On Fri, Feb 03, 2012 at 06:57:06PM +0530, Amit Sahrawat wrote: > > This will cover all the invocations for writepages to be called with > > plugging support. > > Thanks. I'll test it on the major filesystems. But would you > name a few filesystems that are expected to benefit from it? > It's not obvious because some FS ->writepages eventually calls > generic_writepages() which already does plugging. Ant that's exactly where it should stay instead of beeing sprinkled all over the VM code. NAK to the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/