Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756763Ab2BCOxJ (ORCPT ); Fri, 3 Feb 2012 09:53:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56907 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425Ab2BCOxH (ORCPT ); Fri, 3 Feb 2012 09:53:07 -0500 Date: Fri, 3 Feb 2012 15:53:04 +0100 From: Michal Hocko To: Johannes Weiner Cc: KAMEZAWA Hiroyuki , Andrew Morton , linux-kernel , Daisuke Nishimura , Geunsik Lim , linux-mm Subject: Re: [PATCH] Handling of unused variable 'do-numainfo on compilation time Message-ID: <20120203145304.GA18335@tiehlicka.suse.cz> References: <1328258627-2241-1-git-send-email-geunsik.lim@gmail.com> <20120203133950.GA1690@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120203133950.GA1690@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 48 On Fri 03-02-12 14:39:50, Johannes Weiner wrote: > Michal, this keeps coming up, please decide between the proposed > solutions ;-) Hmm, I thought we already sorted this out https://lkml.org/lkml/2012/1/26/25 ? > > On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote: > > Actually, Usage of the variable 'do_numainfo'is not suitable for gcc compiler. > > Declare the variable 'do_numainfo' if the number of NUMA nodes > 1. > > > > Signed-off-by: Geunsik Lim > > --- > > mm/memcontrol.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 556859f..4e17ac5 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page) > > /* threshold event is triggered in finer grain than soft limit */ > > if (unlikely(mem_cgroup_event_ratelimit(memcg, > > MEM_CGROUP_TARGET_THRESH))) { > > - bool do_softlimit, do_numainfo; > > + bool do_softlimit; > > +#if MAX_NUMNODES > 1 > > + bool do_numainfo; > > +#endif > > > > do_softlimit = mem_cgroup_event_ratelimit(memcg, > > MEM_CGROUP_TARGET_SOFTLIMIT); > > -- > > 1.7.8.1 > > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/