Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755961Ab2BCTue (ORCPT ); Fri, 3 Feb 2012 14:50:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49488 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755865Ab2BCTuc (ORCPT ); Fri, 3 Feb 2012 14:50:32 -0500 Date: Fri, 3 Feb 2012 11:50:26 -0800 From: Andrew Morton To: Corey Minyard Cc: Linux Kernel , OpenIPMI Developers , Matthew Garrett Subject: Re: [PATCH 2/6] ipmi: Increase KCS timeouts Message-Id: <20120203115026.9e2a357f.akpm@linux-foundation.org> In-Reply-To: <1328284079-5489-2-git-send-email-cminyard@mvista.com> References: <1328284079-5489-1-git-send-email-cminyard@mvista.com> <1328284079-5489-2-git-send-email-cminyard@mvista.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 24 On Fri, 03 Feb 2012 09:47:55 -0600 Corey Minyard wrote: > From: Matthew Garrett > > We currently time out and retry KCS transactions after 1 second of waiting > for IBF or OBF. This appears to be too short for some hardware. The IPMI > spec says "All system software wait loops should include error timeouts. For > simplicity, such timeouts are not shown explicitly in the flow diagrams. A > five-second timeout or greater is recommended". Change the timeout to five > seconds to satisfy the slow hardware. Several of these patches fix bugs/problems, but there isn't enough info here for me to decide whether we should patch 3.3 or earlier kernels. I'm assuming "3.4 only". > From: Matthew Garrett A dupe. The first one was correct. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/