Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753395Ab2BDPZk (ORCPT ); Sat, 4 Feb 2012 10:25:40 -0500 Received: from mail-tul01m020-f174.google.com ([209.85.214.174]:55706 "EHLO mail-tul01m020-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258Ab2BDPZR convert rfc822-to-8bit (ORCPT ); Sat, 4 Feb 2012 10:25:17 -0500 MIME-Version: 1.0 In-Reply-To: References: <1327021265-22184-1-git-send-email-matthew.r.wilcox@intel.com> <20120121082857.GC32134@elte.hu> <20120121165830.GA9216@elte.hu> Date: Sun, 5 Feb 2012 00:25:16 +0900 Message-ID: Subject: Re: [PATCH] NVMe: Fix compilation on architecturs without readq/writeq From: Hitoshi Mitake To: Linus Torvalds Cc: Ingo Molnar , Matthew Wilcox , Roland Dreier , Andrew Morton , James Bottomley , linux-kernel@vger.kernel.org, hpa@linux.intel.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 24 On Tue, Jan 31, 2012 at 12:05, Linus Torvalds wrote: > On Mon, Jan 30, 2012 at 7:03 PM, Linus Torvalds > wrote: >> ?val |= readl(addr+4) << 32; > > Oops. That needs a cast to u64 before the shift, of course. > > Take all code I write in emails with a pinch of salt - think of it > more as pseudo-code than something that necessarily would work as-is. > > ? ? ? ? ? ? ? ? ?Linus I'll take care, thanks :) -- Hitoshi Mitake h.mitake@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/