Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755083Ab2BEOhR (ORCPT ); Sun, 5 Feb 2012 09:37:17 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:62299 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754702Ab2BEOhP convert rfc822-to-8bit (ORCPT ); Sun, 5 Feb 2012 09:37:15 -0500 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Hillf Danton" Cc: "Marek Szyprowski" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "Kyungmin Park" , "Russell King" , "Andrew Morton" , "KAMEZAWA Hiroyuki" Subject: Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added References: <1328271538-14502-1-git-send-email-m.szyprowski@samsung.com> <1328271538-14502-9-git-send-email-m.szyprowski@samsung.com> Date: Sun, 05 Feb 2012 15:37:07 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: User-Agent: Opera Mail/11.61 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 32 >>>> +static inline bool migrate_async_suitable(int migratetype) >> On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton wrote: >>> Just nitpick, since the helper is not directly related to what async >>> means, how about migrate_suitable(int migrate_type) ? > 2012/2/3 Michal Nazarewicz : >> I feel current name is better suited since it says that it's OK to scan this >> block if it's an asynchronous compaction run. On Sat, 04 Feb 2012 10:09:02 +0100, Hillf Danton wrote: > The input is the migrate type of page considered, and the async is only one > of the modes that compaction should be carried out. Plus the helper is > also used in other cases where async is entirely not concerned. > > That said, the naming is not clear, if not misleading. In the first version the function was called is_migrate_cma_or_movable() which described what the function checked. Mel did not like it though, hence the change to migrate_async_suitable(). Honestly, I'm not sure what would be the best name for function. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/