Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753676Ab2BFGAK (ORCPT ); Mon, 6 Feb 2012 01:00:10 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:51246 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787Ab2BFGAI (ORCPT ); Mon, 6 Feb 2012 01:00:08 -0500 Date: Sun, 5 Feb 2012 23:00:04 -0700 From: Grant Likely To: Michael Neuling Cc: linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Thomas Gleixner , Milton Miller , Rob Herring , Stephen Rothwell , devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions Message-ID: <20120206060004.GB21449@ponder.secretlab.ca> References: <1327700179-17454-1-git-send-email-grant.likely@secretlab.ca> <1327700179-17454-22-git-send-email-grant.likely@secretlab.ca> <24476.1328505761@neuling.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24476.1328505761@neuling.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 47 On Mon, Feb 06, 2012 at 04:22:41PM +1100, Michael Neuling wrote: > > static const struct irq_domain_ops pmac_pic_host_ops = { > > .match = pmac_pic_host_match, > > .map = pmac_pic_host_map, > > - .xlate = pmac_pic_host_xlate, > > + .xlate = irq_domain_xlate_onecell; > > }; > > > > This causes a compile fail (in next-20120206): > arch/powerpc/platforms/powermac/pic.c:294: error: expected '}' before ';' token > Trivial fix below: fixed, thanks. g. > > > > irqdomain/powerpc: Fix compile error in powermac/pic.c > > Error introduced in: > commit 72d6b477675374eafd206720d6c9146520df18ce > Author: Grant Likely > irqdomain/powerpc: Replace custom xlate functions with library functions > > Signed-off-by: Michael Neuling > > diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c > index 3af29d1..92afc38 100644 > --- a/arch/powerpc/platforms/powermac/pic.c > +++ b/arch/powerpc/platforms/powermac/pic.c > @@ -291,7 +291,7 @@ static int pmac_pic_host_map(struct irq_domain *h, unsigned int virq, > static const struct irq_domain_ops pmac_pic_host_ops = { > .match = pmac_pic_host_match, > .map = pmac_pic_host_map, > - .xlate = irq_domain_xlate_onecell; > + .xlate = irq_domain_xlate_onecell, > }; > > static void __init pmac_pic_probe_oldstyle(void) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/