Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754075Ab2BFIMl (ORCPT ); Mon, 6 Feb 2012 03:12:41 -0500 Received: from nat28.tlf.novell.com ([130.57.49.28]:33595 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753491Ab2BFIMk convert rfc822-to-8bit (ORCPT ); Mon, 6 Feb 2012 03:12:40 -0500 Message-Id: <4F2F998202000078000714CD@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Mon, 06 Feb 2012 08:12:34 +0000 From: "Jan Beulich" To: "Dan Magenheimer" Cc: "Jeremy Fitzhardinge" , , "Konrad Wilk" , Subject: RE: [PATCH] xen/tmem: cleanup References: <4F2C06A00200007800071071@nat28.tlf.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 27 >>> On 04.02.12 at 17:42, Dan Magenheimer wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >> Subject: [PATCH] xen/tmem: cleanup >> >> Use 'bool' for boolean variables. Do proper section placement. >> Eliminate an unnecessary export. >> >> Signed-off-by: Jan Beulich >> Cc: Dan Magenheimer >> >> -int tmem_enabled __read_mostly; >> -EXPORT_SYMBOL(tmem_enabled); >> +bool __read_mostly tmem_enabled = false; > > tmem_enabled is used in xen/drivers/xen-selfballoon.c Which can't be built as a module, and hence the symbol doesn't need exporting. This patch (of course, I'm tempted to say) survived build testing. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/