Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754189Ab2BFIOv (ORCPT ); Mon, 6 Feb 2012 03:14:51 -0500 Received: from mail.karo-electronics.de ([81.173.242.67]:55272 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240Ab2BFIOu (ORCPT ); Mon, 6 Feb 2012 03:14:50 -0500 Message-ID: <20271.35831.227679.177366@ipc1.ka-ro> Date: Mon, 6 Feb 2012 09:14:47 +0100 Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: VM 8.1.0 under 23.2.1 (i486-pc-linux-gnu) From: =?us-ascii?Q?=3D=3Futf-8=3FQ=3FLothar=5FWa=3DC3=3D9Fmann=3F=3D?= To: Cc: , Thomas Gleixner Subject: [BUG] genirq: Race condition in ONESHOT IRQ handler disabling IRQ forever Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2422 Lines: 63 Hi, I already sent this to on Feb. 1, 2012 but did not get any response there. So resending to a wider audience with improved subject line: there is a race condition in the threaded IRQ handler code for oneshot interrupts that may lead to disabling an IRQ indefinitely. IRQs are masked before calling the hard-irq handler and are unmasked only after the soft-irq handler has been run. Thus if the hard-irq handler returns IRQ_HANDLED instead of IRQ_WAKE_THREAD, meaning the soft-irq will not be called, the interrupt will remain masked forever. This can happen due to a short pulse on the interrupt line, that triggers the interrupt logic, but goes undetected by the hard-irq handler. The problem can be reproduced with the TSC2007 touch controller driver that uses ONESHOT interrupts. The problem arises also with interrupt controllers that latch a level triggered IRQ until it is acknowledged (like the i.MX28 does). In this case the IRQ status bit will remain asserted after the soft-irq finishes and retrigger the interrupt while the interrupt line is already deasserted. The following patch would solve the problem, but I'm not sure whether it's the Right Thing(TM) to do. Especially wrt. shared interrupts. diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index 470d08c..93beadb 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -146,6 +146,11 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action) /* Fall through to add to randomness */ case IRQ_HANDLED: random |= action->flags; + /* unmask the IRQ that has been left masked + * due to race condition + */ + if (res == IRQ_HANDLED && (action->flags & IRQF_ONESHOT)) + unmask_irq(desc); break; default: Best regards, Lothar Wassmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/