Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447Ab2BFQDb (ORCPT ); Mon, 6 Feb 2012 11:03:31 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37198 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755200Ab2BFQDa (ORCPT ); Mon, 6 Feb 2012 11:03:30 -0500 Date: Mon, 6 Feb 2012 17:03:37 +0100 From: Daniel Vetter To: Dave Airlie Cc: Keith Packard , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Lubos Kolouch Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Force explicit bpp selection for intel_dp_link_required Message-ID: <20120206160337.GB4066@phenom.ffwll.local> Mail-Followup-To: Dave Airlie , Keith Packard , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Lubos Kolouch References: <1327508186-26704-1-git-send-email-keithp@keithp.com> <1327508186-26704-2-git-send-email-keithp@keithp.com> <20120127103010.GB3901@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 3.2.0-1-amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2015 Lines: 48 On Mon, Feb 06, 2012 at 12:12:16PM +0000, Dave Airlie wrote: > On Fri, Jan 27, 2012 at 10:30 AM, Daniel Vetter wrote: > > On Wed, Jan 25, 2012 at 08:16:25AM -0800, Keith Packard wrote: > >> It is never correct to use intel_crtc->bpp in intel_dp_link_required, > >> so instead pass an explicit bpp in to this function. This patch > >> only supports 18bpp and 24bpp modes, which means that 10bpc modes will > >> be computed incorrectly. Fixing that will require more extensive > >> changes, and so must be addressed separately from this bugfix. > >> > >> intel_dp_link_required is called from intel_dp_mode_valid and > >> intel_dp_mode_fixup. > >> > >> * intel_dp_mode_valid is called to list supported modes; in this case, > >> ? the current crtc values cannot be relevant as the modes in question > >> ? may never be selected. Thus, using intel_crtc->bpp is never right. > >> > >> * intel_dp_mode_fixup is called during mode setting, but it is run > >> ? well before ironlake_crtc_mode_set is called to set intel_crtc->bpp, > >> ? so using intel_crtc-bpp in this path can only ever get a stale > >> ? value. > >> > >> Cc: Lubos Kolouch > >> Cc: Adam Jackson > >> Signed-off-by: Keith Packard > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42263 > > Tested-by: camalot@picnicpark.org (Dell Latitude 6510) > > > > Not the original reporter and might not exactly be this bug, but likely. > > -Daniel > > Tested-by: Dave Airlie Another bugzilla for this patch: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44881 Tested-by: Roland Dreier -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/