Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755353Ab2BFQh3 (ORCPT ); Mon, 6 Feb 2012 11:37:29 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35570 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755250Ab2BFQhK (ORCPT ); Mon, 6 Feb 2012 11:37:10 -0500 X-Sasl-enc: IwAZsmOXDOB5HGm0B+ubopVtfVouwnexlwR15t/X94m8 1328546229 Date: Mon, 6 Feb 2012 08:36:49 -0800 From: Greg KH To: Anton Vorontsov Cc: Oleg Nesterov , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , KOSAKI Motohiro , San Mehat , Colin Cross , "Eric W. Biederman" , "Paul E. McKenney" , linux-kernel@vger.kernel.org, kernel-team@android.com, linaro-kernel@lists.linaro.org Subject: Re: [PATCH 3/6] staging: android/lowmemorykiller: Don't grab tasklist_lock Message-ID: <20120206163649.GB10104@kroah.com> References: <20120203163056.GA4190@redhat.com> <20120206162941.GC5117@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120206162941.GC5117@oksana.dev.rtsoft.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 27 On Mon, Feb 06, 2012 at 08:29:41PM +0400, Anton Vorontsov wrote: > Grabbing tasklist_lock has its disadvantages, i.e. it blocks > process creation and destruction. If there are lots of processes, > blocking doesn't sound as a great idea. > > For LMK, it is sufficient to surround tasks list traverse with > rcu_read_{,un}lock(). > > >From now on using force_sig() is not safe, as it can race with an > already exiting task, so we use send_sig() now. As a downside, it > won't kill PID namespace init processes, but that's not what we > want anyway. > > Suggested-by: Oleg Nesterov > Signed-off-by: Anton Vorontsov Are these last 4 patches independant of the first 2 and can be taken through the staging tree now? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/