Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755667Ab2BFR1N (ORCPT ); Mon, 6 Feb 2012 12:27:13 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:44402 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755513Ab2BFR1L (ORCPT ); Mon, 6 Feb 2012 12:27:11 -0500 Date: Mon, 6 Feb 2012 09:27:06 -0800 From: Tejun Heo To: Linus Torvalds Cc: Vivek Goyal , Jens Axboe , Shaohua Li , lkml , Knut Petersen , mroos@linux.ee Subject: Re: [patch]block: fix ioc locking warning Message-ID: <20120206172706.GB21292@google.com> References: <1328514611.21268.66.camel@sli10-conroe> <20120206151219.GC30752@redhat.com> <4F2FFB21.9000202@kernel.dk> <20120206163721.GF30752@redhat.com> <20120206164428.GA21292@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 29 Hello, On Mon, Feb 06, 2012 at 08:58:49AM -0800, Linus Torvalds wrote: > On Mon, Feb 6, 2012 at 8:44 AM, Tejun Heo wrote: > > > > Yeah, this seems better to me. ?Jens, if you're gonna amend the > > commit, please consider collapsing the following patch into the > > original patch too. ?Thanks. > > Guys, is it *really* worth it to do all these crazy games? > > How bad is it to just always use the async freeing, instead of this > clearly very fragile crazy direct-freeing-with-serious-locking-issues > thing? It's one wq scheduling on exit for any task which has issued an IO. I don't think it would matter except for task fork/exit microbenchs (or workloads which approximate to that). I'll get some measurements and strip the optimization if it doesn't really show up. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/