Message-ID: <1328561164.2261.258.camel@groeck-laptop>
Subject: Re: [PATCH v5 4/5] hwmon: add MAX197 support
From: Guenter Roeck <guenter.roeck@ericsson.com>
Reply-To: guenter.roeck@ericsson.com
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
CC: "x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
        Jean Delvare <khali@linux-fr.org>
Date: Mon, 6 Feb 2012 12:46:04 -0800
In-Reply-To: <20120206151507.73a23eb8@v0nbox>
References: <1328130344-18836-1-git-send-email-vivien.didelot@savoirfairelinux.com>
	 <1328130344-18836-5-git-send-email-vivien.didelot@savoirfairelinux.com>
	 <1328132138.2261.116.camel@groeck-laptop> <20120206151507.73a23eb8@v0nbox>
Organization: Ericsson
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 834
Lines: 25

Hi Vivien,

On Mon, 2012-02-06 at 15:15 -0500, Vivien Didelot wrote:
[ ... ]
> 
> BTW, about the TS-5500 ADC part, is a platform ts5500_adc.c file the
> better solution, or should the device be declared in the ts5500.c
> platform code?
> 
I would suggest to declare it in the ts5500.c platform code. That seems
to be the common approach as far as I can see.

platform_add_devices() works pretty well for this. It saves you from
having to call platform_device_register() for each device separately.
Obviously that only works if all devices are declared in a single file.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/