Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756628Ab2BGBHT (ORCPT ); Mon, 6 Feb 2012 20:07:19 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:50058 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756580Ab2BGBHP (ORCPT ); Mon, 6 Feb 2012 20:07:15 -0500 MIME-Version: 1.0 In-Reply-To: <20120206235733.GY1426@atomide.com> References: <74CDBE0F657A3D45AFBB94109FB122FF178E5D3160@HQMAIL01.nvidia.com> <4F2F6AE2.1040504@nvidia.com> <20120206190315.GU1426@atomide.com> <20120206210456.GV1426@atomide.com> <20120206235733.GY1426@atomide.com> Date: Tue, 7 Feb 2012 02:07:14 +0100 Message-ID: Subject: Re: An extremely simplified pinctrl bindings proposal From: Linus Walleij To: Tony Lindgren Cc: Stephen Warren , Dong Aisheng , Shawn Guo , Dong Aisheng-B29396 , "Sascha Hauer (s.hauer@pengutronix.de)" , "rob.herring@calxeda.com" , "kernel@pengutronix.de" , "cjb@laptop.org" , "Simon Glass (sjg@chromium.org)" , Thomas Abraham , "Grant Likely (grant.likely@secretlab.ca)" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 35 On Tue, Feb 7, 2012 at 12:57 AM, Tony Lindgren wrote: >> I'm not sure if I'm following completely, if this is inside the devicetree-based >> driver file, would it work to just add a struct dentry * to the >> pinctrl_desc where you put a per-driver file? > > I was thinking generic debufs entries for all drivers. OK. >> Or maybe add extern void pinctrl_add_debugfs(struct dentry *) that adds >> a new file to the existing per-driver directory through the core and then >> have this add that file? > > Sounds like you've thought it further than me already :) > > Maybe that's the way to go to solve the one register for > multiple pins issue. > >> Or did you mean that the core.c should be register-aware? > > I was just thinking string name ignoring core.c, so that would > be the pinctrl_add_debugfs() option then. Do you see problems > with this approach? No probs, something like that you call any number of times after registering the core device should work fine I guess. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/