Date: Tue, 7 Feb 2012 09:29:07 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Dmitry Antipov <dmitry.antipov@linaro.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
        patches@linaro.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Venkatesh Pallipadi <venki@google.com>
Subject: Re: [PATCH] sched: move CONFIG_IRQ_TIME_ACCOUNTING to common code
Message-ID: <20120207082907.GB12821@elte.hu>
References: <1328080789-18277-1-git-send-email-dmitry.antipov@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1328080789-18277-1-git-send-email-dmitry.antipov@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 951
Lines: 28


* Dmitry Antipov <dmitry.antipov@linaro.org> wrote:

> Since CONFIG_IRQ_TIME_ACCOUNTING is architecture-agnostic, 
> move it from x86 area to common code.
> 
> Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>
> ---
>  arch/x86/Kconfig  |   11 -----------
>  lib/Kconfig.debug |   11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)

That's not enough, right now on x86 this code needs special 
architecture glue, see how the noirqtime flag is used to call 
into enable_sched_clock_irqtime() after TSC init.

So if you apply your patch and boot CONFIG_IRQ_TIME_ACCOUNTING=y 
on say an ARM system, nothing will be done, because 
sched_clock_irqtime is always zero.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/