Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755790Ab2BGL0R (ORCPT ); Tue, 7 Feb 2012 06:26:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609Ab2BGL0Q (ORCPT ); Tue, 7 Feb 2012 06:26:16 -0500 Message-ID: <4F310A4F.6060602@redhat.com> Date: Tue, 07 Feb 2012 12:26:07 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Christian Hoff , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, rusty@rustcorp.com.au, kvm@vger.kernel.org Subject: Re: Pe: [PATCH v5 1/3] virtio-scsi: first version References: <4F30F4EE.4080607@redhat.com> <20120207111041.GA6674@redhat.com> In-Reply-To: <20120207111041.GA6674@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 28 On 02/07/2012 12:10 PM, Michael S. Tsirkin wrote: >>> Also, lun[1] = sc->device->id means that only 255 SCSI target IDs will be >>> > >supported. Think about bigger usage scenarios, such as FCP networks with >>> > >several hundred HBAs in the net. If you want to have the target ID<->HBA >>> > >mapping the same as on the guest as on the host, then 255 virtual target >>> > >IDs could be a limit. >> > >> > I think you would hit other scalability limitations well before >> > that. I plan to give each target its own MSI-X interrupt, but there >> > is no infinite supplies of those either. > virtio-pci generally lets guests share MSI-X vectors between queues, > why not allow this here? Yes, of course. However, with dozens of queues, many of them will share the same vector and all of them will be examined when you get the interrupt. Even if you find the right balance between sharing (because you have to) and separating (because of scalability), I wouldn't be surprised if more than 255 targets do not work too well. Anyway multiqueue is not even in this patchset, so there's more work to do before we can worry. :) Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/