Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Subject: RE: [PATCH 01/11] dmaengine: add context parameter toprep_slave_sgand prep_dma_cyclic
Date: Tue, 7 Feb 2012 06:19:04 -0800
Message-ID: <0CE8B6BE3C4AD74AB97D9D29BD24E552028C2A7B@CORPEXCH1.na.ads.idt.com>
In-Reply-To: <1328624057.26182.144.camel@vkoul-udesk3>
Thread-Topic: [PATCH 01/11] dmaengine: add context parameter toprep_slave_sgand prep_dma_cyclic
Thread-Index: AczloumPjEA39IcxT+6Zk5nb3tRiYAAAFpnw
References: <1328218341-31436-1-git-send-email-alexandre.bounine@idt.com> <1328218341-31436-2-git-send-email-alexandre.bounine@idt.com> <20120202214350.GB4432@flint.arm.linux.org.uk> <0CE8B6BE3C4AD74AB97D9D29BD24E55202872683@CORPEXCH1.na.ads.idt.com> <1328529182.26182.92.camel@vkoul-udesk3> <0CE8B6BE3C4AD74AB97D9D29BD24E552028729F9@CORPEXCH1.na.ads.idt.com> <1328542134.26182.111.camel@vkoul-udesk3> <20120206155318.GA20852@flint.arm.linux.org.uk> <0CE8B6BE3C4AD74AB97D9D29BD24E55202872AB1@CORPEXCH1.na.ads.idt.com> <1328551625.26182.139.camel@vkoul-udesk3> <0CE8B6BE3C4AD74AB97D9D29BD24E55202872B3D@CORPEXCH1.na.ads.idt.com> <1328585993.26182.143.camel@vkoul-udesk3> <0CE8B6BE3C4AD74AB97D9D29BD24E552028C2A5D@CORPEXCH1.na.ads.idt.com> <1328624057.26182.144.camel@vkoul-udesk3>
From: "Bounine, Alexandre" <Alexandre.Bounine@idt.com>
To: Vinod Koul <vinod.koul@intel.com>
CC: Russell King <rmk@arm.linux.org.uk>, <dan.j.williams@intel.com>,
        <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Kumar Gala <galak@kernel.crashing.org>,
        Matt Porter <mporter@kernel.crashing.org>,
        Li Yang <leoli@freescale.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 996
Lines: 23

On Tue, Feb 07, 2012 9:14 AM, Vinod Koul wrote:
> 
> On Tue, 2012-02-07 at 06:01 -0800, Bounine, Alexandre wrote:
> > Currently function private_candidate() allows filtering function
> > not to be specified and therefore skip the filter check.
> > It may be a good safety measure to ensure that channels specified
> > as DMA_SLAVE_EXT provide a corresponding filter routine so they
> > positively identify dma channel that will accept intended extra
> > parameter.
> > I assume that a system may have more than one dmac registered as
> > DMA_SLAVE_EXT.
> >
> > This is what I have for RapidIO - the filter call ensures that DMA
> > channel is associated with a RapidIO controller that provides access
> > to the specified SRIO device.
> For slave-dma it's better to have a filter :)

Better, but it can get away without it ;))

Alex.


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?