Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755641Ab2BGPon (ORCPT ); Tue, 7 Feb 2012 10:44:43 -0500 Received: from mx2.netapp.com ([216.240.18.37]:31443 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287Ab2BGPol (ORCPT ); Tue, 7 Feb 2012 10:44:41 -0500 X-IronPort-AV: E=Sophos;i="4.73,377,1325491200"; d="scan'208";a="623246560" Message-ID: <4F3146E0.4040704@netapp.com> Date: Tue, 07 Feb 2012 10:44:32 -0500 From: Bryan Schumaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: "Myklebust, Trond" CC: "Schumaker, Bryan" , Stanislav Kinsbursky , "linux-nfs@vger.kernel.org" , "xemul@parallels.com" , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jbottomley@parallels.com" , "bfields@fieldses.org" , "davem@davemloft.net" , "devel@openvz.org" Subject: Re: [PATCH 1/4] NFS: make nfs_client_list per net ns References: <20120123172605.29637.15682.stgit@localhost6.localdomain6> <4F3143F4.3010502@netapp.com> <1328628888.4124.16.camel@lade.trondhjem.org> In-Reply-To: <1328628888.4124.16.camel@lade.trondhjem.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 37 On 02/07/12 10:34, Myklebust, Trond wrote: > On Tue, 2012-02-07 at 10:32 -0500, Bryan Schumaker wrote: >> I fixed up my bisect and identified this patch instead. The problem I'm seeing is: >> >> CC [M] fs/nfs/delegation.o >> CC [M] fs/nfs/idmap.o >> fs/nfs/idmap.c: In function 'rpc_pipefs_event': >> fs/nfs/idmap.c:535:9: error: implicit declaration of function 'net_generic' [-Werror=implicit-function-declaration] >> fs/nfs/idmap.c:535:50: error: 'nfs_net_id' undeclared (first use in this function) >> fs/nfs/idmap.c:535:50: note: each undeclared identifier is reported only once for each function it appears in >> fs/nfs/idmap.c:540:82: error: dereferencing pointer to incomplete type >> fs/nfs/idmap.c:540:224: error: dereferencing pointer to incomplete type >> cc1: some warnings being treated as errors >> >> make[2]: *** [fs/nfs/idmap.o] Error 1 >> make[1]: *** [fs/nfs] Error 2 >> make: *** [fs] Error 2 >> >> I think you need to add: #include "netns.h" to idmap.c. >> >> - Bryan > > That should already be there in the 'devel' branch. See commit > 17347d03c008e2f504c33bb4905cdad0abc01319. > Yes, but once I fixed this I was able to find the initial problem I was searching for (I have no idea how git led me to the wrong patch on my first attempt). - Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/