Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757090Ab2BGWfM (ORCPT ); Tue, 7 Feb 2012 17:35:12 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:59215 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756370Ab2BGWfK (ORCPT ); Tue, 7 Feb 2012 17:35:10 -0500 MIME-Version: 1.0 In-Reply-To: <1328592178.21268.78.camel@sli10-conroe> References: <20120206151219.GC30752@redhat.com> <4F2FFB21.9000202@kernel.dk> <20120206163721.GF30752@redhat.com> <20120206164428.GA21292@google.com> <20120206172706.GB21292@google.com> <20120206203604.GC21292@google.com> <20120207003948.GE21292@google.com> <1328575430.21268.69.camel@sli10-conroe> <20120207005900.GF21292@google.com> <1328592178.21268.78.camel@sli10-conroe> From: Linus Torvalds Date: Tue, 7 Feb 2012 14:34:48 -0800 X-Google-Sender-Auth: xxKc6Hqyw9kop7OC5p5KDnHObQk Message-ID: Subject: Re: [patch]block: fix ioc locking warning To: Shaohua Li Cc: Tejun Heo , Vivek Goyal , Jens Axboe , lkml , Knut Petersen , mroos@linux.ee Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 17 On Mon, Feb 6, 2012 at 9:22 PM, Shaohua Li wrote: > On Mon, 2012-02-06 at 16:59 -0800, Tejun Heo wrote: >> * Test with the this_q != locked_q trylock patch. > this one slightly reduces the regression. without it, the regression is > about 17%, with it, the regression is about 12%. Test result is stable. What happens when you remove the fast-case entirely? See the other patch by Tejun with the subject "[PATCH] block: strip out locking optimization in put_io_context()" Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/