Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869Ab2BHGLY (ORCPT ); Wed, 8 Feb 2012 01:11:24 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:35560 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270Ab2BHGLX convert rfc822-to-8bit (ORCPT ); Wed, 8 Feb 2012 01:11:23 -0500 MIME-Version: 1.0 In-Reply-To: <20120208050119.GE8930@ram-ThinkPad-T61> References: <1328424908-6385-1-git-send-email-yinghai@kernel.org> <1328424908-6385-5-git-send-email-yinghai@kernel.org> <20120208043517.GD8930@ram-ThinkPad-T61> <20120208050119.GE8930@ram-ThinkPad-T61> Date: Tue, 7 Feb 2012 22:11:22 -0800 X-Google-Sender-Auth: AYvcavVTYD5lQjsD8-8nsNB3JGA Message-ID: Subject: Re: [PATCH 4/9] PCI: Fix cardbus bridge resources as optional size handling From: Yinghai Lu To: Ram Pai Cc: Jesse Barnes , Dominik Brodowski , Linus Torvalds , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 39 On Tue, Feb 7, 2012 at 9:01 PM, Ram Pai wrote: > > ..snip.. >> ? ? ? ?* If we have prefetchable memory support, allocate >> ? ? ? ?* two regions. ?Otherwise, allocate one region of >> ? ? ? ?* twice the size. >> ? ? ? ?*/ >> ? ? ? if (ctrl & PCI_CB_BRIDGE_CTL_PREFETCH_MEM0) { >> ? ? ? ? ? ? ? b_res[2].start = pci_cardbus_mem_size; >> ? ? ? ? ? ? ? b_res[2].end = b_res[2].start + pci_cardbus_mem_size - 1; >> ? ? ? ? ? ? ? b_res[2].flags |= IORESOURCE_MEM | IORESOURCE_PREFETCH | >> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? IORESOURCE_STARTALIGN; >> ? ? ? ? ? ? ? if (realloc_head) { >> ? ? ? ? ? ? ? ? ? ? ? b_res[2].end -= pci_cardbus_mem_size; >> ? ? ? ? ? ? ? ? ? ? ? add_to_list(realloc_head, bridge, b_res+2, >> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?pci_cardbus_mem_size, pci_cardbus_mem_size); >> ? ? ? ? ? ? ? } >> >> ? ? ? ? ? ? ? /* reduce that to half */ >> ? ? ? ? ? ? ? b_res_3_size = pci_cardbus_mem_size; >> ? ? ? } > > ACK. Ok. got it. This looks correct. Good, So we have Acked-by: Ram Pai Tested-by: Dominik Brodowski Hope Jesse will not miss to add them Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/