Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078Ab2BHNFt (ORCPT ); Wed, 8 Feb 2012 08:05:49 -0500 Received: from mail.skyhub.de ([78.46.96.112]:42625 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756855Ab2BHNFr (ORCPT ); Wed, 8 Feb 2012 08:05:47 -0500 Date: Wed, 8 Feb 2012 14:05:41 +0100 From: Borislav Petkov To: Kevin Winchester Cc: Ingo Molnar , Nick Bowler , Randy Dunlap , "H. Peter Anvin" , Thomas Gleixner , LKML Subject: Re: MCE, AMD: Hide smp-only code around CONFIG_SMP Message-ID: <20120208130541.GA2613@x1.osrc.amd.com> Mail-Followup-To: Borislav Petkov , Kevin Winchester , Ingo Molnar , Nick Bowler , Randy Dunlap , "H. Peter Anvin" , Thomas Gleixner , LKML References: <1328209817-18913-1-git-send-email-bp@alien8.de> <20120202193702.GA9502@elliptictech.com> <20120202202427.GA2234@x1.osrc.amd.com> <20120203191801.GA2846@x1.osrc.amd.com> <20120207095746.GH15359@elte.hu> <20120208101956.GA1772@x1.osrc.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 33 On Wed, Feb 08, 2012 at 08:22:11AM -0400, Kevin Winchester wrote: > Does this work? arch/x86/kernel/cpu/mcheck/mce_amd.c includes > rather than directly. And > only includes for the CONFIG_SMP case. Or perhaps one of > the other includes in mce_amd.c includes ? It looks like it: $ make arch/x86/kernel/cpu/mcheck/mce_amd.i $ grep 'asm/smp.h' arch/x86/kernel/cpu/mcheck/mce_amd.i # 1 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" 1 # 13 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" # 14 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" 2 # 16 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" 2 and this one pulls in the cpu_llc* crap. # 183 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" # 225 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" # 236 "/home/boris/kernel/linux-2.6/arch/x86/include/asm/smp.h" So some other headers seem to pull in asm/smp.h. HTH. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/